Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify tailwind engine routing and fix stuff #9321

Merged
merged 2 commits into from Nov 22, 2023
Merged

Simplify tailwind engine routing and fix stuff #9321

merged 2 commits into from Nov 22, 2023

Conversation

DanielBelmes
Copy link
Contributor

Summary

  • renamed location in admin routes as it overrides the reserved var location
  • added key to a list in admin page
  • added tailwind property to engine element
  • removed unesessary {} in main.tsx and using tailwind property
  • removed engine_tw

References

Issue user reported to @barankyle

QA Steps

Open Incognito
Go to EE/admin
Redirect to index page

@speigg speigg added this pull request to the merge queue Nov 22, 2023
Merged via the queue into dev with commit 9f5c4a0 Nov 22, 2023
7 checks passed
@speigg speigg deleted the FixApptoAppTWNav branch November 22, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@speigg speigg speigg approved these changes

@barankyle barankyle barankyle approved these changes

@HexaField HexaField Awaiting requested review from HexaField

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielBelmes @speigg @barankyle