Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Studio Scene Loading, Other scene cleanup #9349

Merged
merged 8 commits into from Dec 1, 2023
Merged

Rework Studio Scene Loading, Other scene cleanup #9349

merged 8 commits into from Dec 1, 2023

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Nov 29, 2023 •
edited

Summary

  • Cleans up mount and unmount for ModelComponent
  • removes unused rootEntity and roots APIs in EntityTreeComponent
  • studio uses scenePath param instead of scene name and project name (with backwards compat route)

References

closes #insert number here

QA Steps

@HexaField HexaField marked this pull request as ready for review November 30, 2023 01:37
@HexaField HexaField marked this pull request as draft November 30, 2023 01:39
@HexaField HexaField changed the title Model cleanup remove unused tree apis Rework Studio Scene Loading, Other scene cleanup Nov 30, 2023
@HexaField HexaField marked this pull request as ready for review December 1, 2023 00:13
@HexaField HexaField merged commit 0f83abc into dev Dec 1, 2023
13 checks passed
@HexaField HexaField deleted the model-cleanup-remove-unused-tree-apis branch December 1, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinomut1 dinomut1 dinomut1 approved these changes

@MoizAdnan MoizAdnan Awaiting requested review from MoizAdnan

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HexaField @dinomut1