Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured new users do not get avatars missing resources #9407

Merged
merged 2 commits into from Dec 11, 2023

Conversation

barankyle
Copy link
Member

Added logic to createNewUser to check that the avatar randomly selected for a new user has a valid model and thumbnail resource, and remove that avatar from the list to choose from if either is missing.

Summary

References

closes #insert number here

QA Steps

Added logic to createNewUser to check that the avatar randomly
selected for a new user has a valid model and thumbnail resource,
and remove that avatar from the list to choose from if either
is missing.
@barankyle
Copy link
Member Author

@hanzlamateen I was initially just going to read the existence (or not) of the resources off of the avatars object returned from avatarPath.find, but they weren't there. I finally realized that was because the modelResource and thumbnailResource resolvers are on avatarExternalResolver, and this is an internal call. I wasn't sure we wanted to move them to avatarResolver just for this situation; do you know of a way to force a specific resolver to trigger by adding things to the request alone?

Since these resolvers are for external requests, I'd tried adding provider to the params to make it look like an external request, but that ran into a different issue, namely that there was no authentication headers since the user doesn't exist yet. Manually GETting the resources like I did doesn't seem like the most elegant solution, but I'm not sure if there's a better way to do it.

@hanzlamateen
Copy link
Member

@hanzlamateen I was initially just going to read the existence (or not) of the resources off of the avatars object returned from avatarPath.find, but they weren't there. I finally realized that was because the modelResource and thumbnailResource resolvers are on avatarExternalResolver, and this is an internal call. I wasn't sure we wanted to move them to avatarResolver just for this situation; do you know of a way to force a specific resolver to trigger by adding things to the request alone?

Since these resolvers are for external requests, I'd tried adding provider to the params to make it look like an external request, but that ran into a different issue, namely that there was no authentication headers since the user doesn't exist yet. Manually GETting the resources like I did doesn't seem like the most elegant solution, but I'm not sure if there's a better way to do it.

@barankyle avatarResolver will be executed even for internal calls. So as in your case these resources can be move to avatarResolver.

@HexaField HexaField merged commit 6b7cb60 into dev Dec 11, 2023
13 checks passed
@HexaField HexaField deleted the create-new-user-ignore-avatars-missing-resources branch December 11, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants