Scene Loading & Editor Snapshot Unit Tests #9468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
HexaField
requested changes
Dec 19, 2023
| process.env.NODE_TLS_REJECT_UNAUTHORIZED = '1' | ||
|
|
||
| const modelLink = '/packages/projects/default-project/assets/collisioncube.glb' | ||
| const testScene = { |
There was a problem hiding this comment.
let's put this in a .json file and import it to improve readability of this file
There was a problem hiding this comment.
roger that, ill put it right next to the file
| import { FogSettingsComponent } from '../../../engine/src/scene/components/FogSettingsComponent' | ||
| import { EditorControlFunctions } from './EditorControlFunctions' | ||
|
|
||
| const testScene = { |
There was a problem hiding this comment.
let's put this in a .json file and import it to improve readability of this file
HexaField
approved these changes
Dec 19, 2023
HexaField
changed the title
HexaField
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds tests for the scene loading functionality in the codebase. It includes tests for loading an empty scene, loading a scene with a root entity, loading a scene with a child entity, and unloading a child entity.