Fix GLTF Export #9483
Merged
Fix GLTF Export #9483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
animations reference model asset instead of scene remove lightmapbaker
…into fix-gltf-export
HexaField
approved these changes
Dec 22, 2023
HexaField
added a commit
that referenced
this pull request
Dec 22, 2023
This reverts commit ec91819.
HexaField
added a commit
that referenced
this pull request
Dec 22, 2023
HexaField
added a commit
that referenced
this pull request
Dec 22, 2023
Merged
Rezmason
pushed a commit
that referenced
this pull request
Dec 26, 2023
* add proxified group to all scene entities animations reference model asset instead of scene remove lightmapbaker * check for material before csm teardown * ci/cd
Rezmason
pushed a commit
that referenced
this pull request
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a proxified Group to every scene entity, so that the GLTFExporter has objects to traverse in its export function
Reroutes the Model Component's scene field to point to this proxified Group
Reroutes all Animation System references to the Model Component's asset field instead of scene
Begins to separate exportGLTF and loadGLTFModel from being strictly used by ModelComponent