Fix shadow and camera #9493
Merged
Fix shadow and camera #9493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
approved these changes
Dec 23, 2023
Rezmason
pushed a commit
that referenced
this pull request
Dec 26, 2023
Co-authored-by: HexaField <joshfield999@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes camera input regression we got with some changes @AidanCaruso was doing to fix another bug. Hotfixing with a mobile check as the functionality worked well on Mobile.
Drop Shadow was broken with the Avatar ECS changes. I've ensure that the shadow is only applied on the root avatar entity and then I have locked it to the groundPlane for now since we are unable to remove Avatars from layer queries due to #9492