Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated sceneID logic in LocationDrawer #9516

Merged
merged 4 commits into from Dec 29, 2023
Merged

Updated sceneID logic in LocationDrawer #9516

merged 4 commits into from Dec 29, 2023

Conversation

MoizAdnan
Copy link
Member

@MoizAdnan MoizAdnan commented Dec 28, 2023 •
edited

  • Updated how scene id is set in location drawer. Rather than replace projects/, it is now generic and replaces anything before first /
  • Updated file-browser methods to use Promise.all instead of loop

@MoizAdnan MoizAdnan changed the title Bug fixes for saveScene Updated sceneID logic in LocationDrawer Dec 28, 2023
@MoizAdnan MoizAdnan marked this pull request as ready for review December 28, 2023 13:35
@hanzlamateen hanzlamateen added this pull request to the merge queue Dec 29, 2023
Merged via the queue into dev with commit 278f794 Dec 29, 2023
8 checks passed
@hanzlamateen hanzlamateen deleted the scene-save-fixes branch December 29, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barankyle barankyle barankyle approved these changes

@hanzlamateen hanzlamateen hanzlamateen approved these changes

@HexaField HexaField Awaiting requested review from HexaField

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MoizAdnan @barankyle @hanzlamateen