Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect to original location after login #9549

Merged
merged 6 commits into from Jan 8, 2024
Merged

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Jan 3, 2024

Summary

  • Redirect to the studio's location after logging in
  • Redirect to admin location when after logging in
  • Add the navigation state when routing from studio or admin to react-route's navigate state.

References

closes #9524

QA Steps

Studio

2024-01-03.at.17.53.58.mp4

Admin

2024-01-03.at.18.08.19.mp4

@aditya-mitra aditya-mitra marked this pull request as draft January 3, 2024 12:28
@aditya-mitra aditya-mitra marked this pull request as ready for review January 3, 2024 12:40
@aditya-mitra aditya-mitra changed the title redirect to studio after login redirect to original location after login Jan 3, 2024
@hanzlamateen
Copy link
Member

@aditya-mitra just wondering if the redirect/from url can in query string on sigin page to persist it between refresh?

@hanzlamateen
Copy link
Member

hanzlamateen commented Jan 4, 2024

I think he can get rid of that initial / or %2F as well
image

Copy link
Member

@hanzlamateen hanzlamateen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine. Adding @HexaField to give it a second look into code changes.

@speigg
Copy link
Member

speigg commented Jan 5, 2024

looks good to me!

@HexaField HexaField merged commit 2108def into dev Jan 8, 2024
13 checks passed
@HexaField HexaField deleted the feat/redirect-studio branch January 8, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect to homepage if user doesn't have studio permission
4 participants