IK Hint Fixes #9569
Merged
IK Hint Fixes #9569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AidanCaruso
reviewed
Jan 7, 2024
| _quat2.multiply(rightFootRotation) | ||
| _quat2.multiply(Q_X_90) | ||
| } else { | ||
| /** I don't know why flipped models don't need this foot angle applied, nor why it needs to be halved */ |
There was a problem hiding this comment.
This is likely because our flipped models happen to only ever be VRM, it would seem raw bones on natively exported VRM also use identity quaternions in bind pose, though I'm not sure why that is.
AidanCaruso
requested changes
Jan 7, 2024
| const leftFootTargetBlendWeight = AvatarIKTargetComponent.blendWeight[ikTargetLeftFoot] | ||
| const rightFootTargetBlendWeight = AvatarIKTargetComponent.blendWeight[ikTargetRightFoot] | ||
| if (!leftFootEntity || !rightFootEntity) return | ||
| AvatarIKTargetComponent.blendWeight[leftFootEntity] = 1 |
There was a problem hiding this comment.
I assume these were left in from testing. These will cause the ik solve to always run regardless of being in an immersive session.
AidanCaruso
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
closes #insert number here
QA Steps