Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Prefabricated Components #9612

Closed
wants to merge 11 commits into from
Closed

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Jan 12, 2024

Summary

  • add default component prefabs in scene assets panel
  • ability drag and drop the component prefabs into the scene
  • added 2 component prefabs

References

closes #9291

QA Steps

2024-01-12.at.15.56.20.mp4

@aditya-mitra aditya-mitra marked this pull request as draft January 12, 2024 09:20
@aditya-mitra aditya-mitra changed the title Default Prefabricated Default Prefabricated Components Jan 12, 2024
@aditya-mitra aditya-mitra marked this pull request as ready for review January 12, 2024 10:34
@aditya-mitra aditya-mitra requested review from HexaField and dinomut1 and removed request for HexaField January 12, 2024 10:34
Copy link
Member

@dinomut1 dinomut1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot drag and drop these onto the scene hierarchy. Also, double click should create a prefab at the origin.

@aditya-mitra
Copy link
Collaborator Author

I cannot drag and drop these onto the scene hierarchy. Also, double click should create a prefab at the origin.

added them!

2024-01-18.at.11.08.18.mp4

Copy link
Member

@dinomut1 dinomut1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to debug: When an Animated Model is created, clicking on it in the hierarchy panel causes UI to crash
image

@HexaField
Copy link
Member

closing in favour of #10047

@HexaField HexaField closed this Apr 21, 2024
@aditya-mitra aditya-mitra deleted the feat/assets-default-prefabs branch April 22, 2024 03:51
@dinomut1 dinomut1 restored the feat/assets-default-prefabs branch April 23, 2024 22:00
@dinomut1 dinomut1 reopened this Apr 23, 2024
@dinomut1
Copy link
Member

We want to use this structure for defining the prefabs, let's just make sure this is up to date with dev and has all the up to date prefab definitions as outlined in the component doc

@dinomut1
Copy link
Member

ok we're just making a new PR to handle this since Jiatong is taking this over

@dinomut1 dinomut1 closed this Apr 23, 2024
@aditya-mitra aditya-mitra deleted the feat/assets-default-prefabs branch April 24, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Default Prefabs for Common Component Types
3 participants