-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ONEX Network #129
Comments
Auditing time: 1 day |
@RideSolo assigned. |
Auditing time: 1 day |
@pro100skm assigned. |
Auditing time 1 day. |
@MrCrambo assigned |
1. SummaryONEX smart contract security audit report performed by Callisto Security Audit Department ERC223 implementation, Proof-of-Stake Token on Ethereum Classic Network. This is an alternative method to the more widely known process used by bitcoin; Proof of Work (POW). 2. In scope
3. FindingsIn total, 4 issues were reported including:
3.1. Block Gas Limit ErrorSeverity: mediumDescriptionWhen executing Code snippethttps://github.com/RideSolo/ONEX-Network/blob/master/contracts/ONEX.sol#L241#L252 3.2. Staker RewardSeverity: mediumDescriptionIf a token transfer occurs and a staker didn't claim his reward by calling transfer function using Following onex description "ONEX provides two methods to trigger ONEX staking: 1.Sending a transaction to your own address with any amount of ONEX. 2.Using MyEtherWallet.com or Mist or any other software that can interact with contracts to execute mint() function.", contract developers should inform the stakers that if they transfer tokens after the minimum staking period without claiming their stake will result in the loss of their reward. Implementing a simple mechanism that allows the addition of the reward to the stakers account if they meet the requirement when transfering tokens to another address can be implemented easily. Code snippethttps://github.com/RideSolo/ONEX-Network/blob/master/contracts/ONEX.sol#L150 https://github.com/RideSolo/ONEX-Network/blob/master/contracts/ONEX.sol#L169 3.3. Token Transfer to Address 0x0Severity: lowDescriptionOnex Token do not require the Code snippethttps://github.com/RideSolo/ONEX-Network/blob/master/contracts/ONEX.sol#L144 3.4. Wrong
|
Audit request
ERC223 implementation, Proof-of-Stake Token on Ethereum Classic Network. This is an alternative method to the more widely known process used by bitcoin; Proof of Work (POW).
Address: 0x085b0fdf115aa9e16ae1bddd396ce1f993c52220
Website: https://onex.network
Source code
https://github.com/HighlanderNetwork/ONEX-Network/tree/master/contracts
Disclosure policy
Publish the report
Also please send report to: highlandernetwork@protonmail.com
Platform
Ethereum Classic (ETC)
Complexity
Low
The text was updated successfully, but these errors were encountered: