Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ethicapp-v2-ca] Agregar dominio de API de Content Analysis a .env #303

Open
claudio-alvarez opened this issue Apr 8, 2024 · 0 comments
Open

[ethicapp-v2-ca] Agregar dominio de API de Content Analysis a .env #303

claudio-alvarez opened this issue Apr 8, 2024 · 0 comments
Assignees
@sdiazgt
Labels
enhancement Improvement to an existing feature

Comments

@claudio-alvarez
Copy link
Collaborator

Descripción general

En visor.js en backend existe hardcodeo de la URL del servicio de análisis de contenido, lo cual limita las opciones de configuración para producción. Lo correcto sería definir al menos el hostname (podría ser tambien API_ROOT_URL) para dicha API en .env, de modo que luego desde el código de controladores en express pueda ser recuperado.

¿Por qué es necesario?

A fin de permitir que el servicio de análisis de contenido pueda interoperar con EthicApp en configuraciones de producción.
@claudio-alvarez claudio-alvarez added the enhancement Improvement to an existing feature label Apr 8, 2024
@sdiazgt sdiazgt mentioned this issue Apr 22, 2024
Closed
claudio-alvarez added a commit that referenced this issue May 10, 2024
@claudio-alvarez
Merge pull request #305 from EthicApp-Development/issue-303
198d54c 
[ethicapp-v2-ca] Se agrego dominios de API de Content Analysis a .env y Docker-compose #303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdiazgt sdiazgt

Labels
enhancement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@claudio-alvarez @sdiazgt