Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover all Python & C++ tests in CI #121

Closed
axsaucedo opened this issue Jan 24, 2021 · 1 comment · Fixed by #151 or #154
Closed

Cover all Python & C++ tests in CI #121

axsaucedo opened this issue Jan 24, 2021 · 1 comment · Fixed by #151 or #154
Labels
enhancement New feature or request
Projects
0.6.1 0.7.0

Comments

@axsaucedo
Copy link
Member

axsaucedo commented Jan 24, 2021 •
edited

Currently not all tests are run on CI due to limitations on Swifftshader (https://kompute.cc/overview/ci-tests.html#running-vulkan-on-the-cpu). This issue encompassess covering all the Python tests in the CI (whilst still ensuring full completeness in a GPU).

Depending on how large the scope of this, this may have to be tackled in two separate PRs (one for Python and one for C++).

The discussion on #119 covers some context of some approaches that could be explored.
@axsaucedo axsaucedo added the enhancement New feature or request label Jan 24, 2021
@axsaucedo axsaucedo added this to To do in 0.6.0 via automation Jan 24, 2021
@axsaucedo axsaucedo mentioned this issue Jan 24, 2021
Merged
4 tasks
@axsaucedo axsaucedo removed this from To do in 0.6.0 Jan 30, 2021
@axsaucedo axsaucedo added this to To do in 0.6.1 via automation Jan 30, 2021
This was referenced Feb 13, 2021
Closed
Merged
0.6.1 automation moved this from To do to Done Feb 15, 2021
@axsaucedo
Copy link
Member Author

Reopening as C++ tests still need to be updated to cover all

@axsaucedo axsaucedo reopened this Feb 15, 2021
0.6.1 automation moved this from Done to In progress Feb 15, 2021
@axsaucedo axsaucedo added this to To do in 0.7.0 via automation Feb 15, 2021
This was referenced Feb 18, 2021
Closed
Merged
0.7.0 automation moved this from To do to Done Feb 21, 2021
0.6.1 automation moved this from In progress to Done Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
0.6.1
Done
0.7.0
Done
Milestone
No milestone
1 participant
@axsaucedo