Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange item stats to better match in-game display #296

Closed
ejfudd opened this issue Apr 9, 2020 · 1 comment
Closed

Rearrange item stats to better match in-game display #296

ejfudd opened this issue Apr 9, 2020 · 1 comment
Labels

Comments

@ejfudd
Copy link
Contributor

ejfudd commented Apr 9, 2020

Currently TQVaultAE displays the stats in this order:
Prefix
Base item
Suffix

To closer match the game display, it should have the base item stats display below the item name followed by the combined and sorted prefix and suffix stats.

A more complete implementation would take all of the attributes at once and then sort them all based on the in-game display. This would require a change in the way ItemProvider.GetFriendlyNames() works. Currently when the attributes are decoded with GetAttributesFromRecord() they are stored in a List named results. As each DB record is decoded, the results are stored in a string array based on the record being processed (prefix, suffix, base, etc.) and then cleared for the next record. Most likely it was done in this way to support the detailed view in the tooltip. To properly sort all of the attributes, the entire list of attributes would need to be passed to GetAttributesFromRecord() though this would break the detailed view. Another option might be to combine all of the results and then sort them in the classic view though this functionality would need to be added.

Edit: removed simple workaround as that is now addressed in #312

@EtienneLamoureux EtienneLamoureux changed the title Item stat sorting should better match in game display Rearrange item stats to better match in-game display Apr 14, 2020
@hguy
Copy link
Collaborator

hguy commented Apr 5, 2022

@EtienneLamoureux this should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants