You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently TQVaultAE displays the stats in this order:
Prefix
Base item
Suffix
To closer match the game display, it should have the base item stats display below the item name followed by the combined and sorted prefix and suffix stats.
A more complete implementation would take all of the attributes at once and then sort them all based on the in-game display. This would require a change in the way ItemProvider.GetFriendlyNames() works. Currently when the attributes are decoded with GetAttributesFromRecord() they are stored in a List named results. As each DB record is decoded, the results are stored in a string array based on the record being processed (prefix, suffix, base, etc.) and then cleared for the next record. Most likely it was done in this way to support the detailed view in the tooltip. To properly sort all of the attributes, the entire list of attributes would need to be passed to GetAttributesFromRecord() though this would break the detailed view. Another option might be to combine all of the results and then sort them in the classic view though this functionality would need to be added.
Edit: removed simple workaround as that is now addressed in #312
The text was updated successfully, but these errors were encountered:
EtienneLamoureux
changed the title
Item stat sorting should better match in game display
Rearrange item stats to better match in-game display
Apr 14, 2020
Currently TQVaultAE displays the stats in this order:
Prefix
Base item
Suffix
To closer match the game display, it should have the base item stats display below the item name followed by the combined and sorted prefix and suffix stats.
A more complete implementation would take all of the attributes at once and then sort them all based on the in-game display. This would require a change in the way
ItemProvider.GetFriendlyNames()
works. Currently when the attributes are decoded withGetAttributesFromRecord()
they are stored in a List named results. As each DB record is decoded, the results are stored in a string array based on the record being processed (prefix, suffix, base, etc.) and then cleared for the next record. Most likely it was done in this way to support the detailed view in the tooltip. To properly sort all of the attributes, the entire list of attributes would need to be passed toGetAttributesFromRecord()
though this would break the detailed view. Another option might be to combine all of the results and then sort them in the classic view though this functionality would need to be added.Edit: removed simple workaround as that is now addressed in #312
The text was updated successfully, but these errors were encountered: