Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fosphor_display: Filter received tags by EOB #21

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

ejk43
Copy link
Contributor

@ejk43 ejk43 commented May 17, 2018

Hi all, this is based on a discussion I had recently on the IRC about fosphor debugging...

I have a local change to gr-ettus that outputs timetag/sample rate item tags on the output of each rx_streamer, which broke fosphor... It turns out fosphor is using item tags for framing, but was not filtering based on end-of-burst.

This quick fix will let us add other item tags to gnuradio streams going into the fosphor display without breaking fosphor.

@mbr0wn
Copy link
Contributor

mbr0wn commented May 18, 2018

@trungnob Weren't you running fosphor on the E310?

@ejk43
Copy link
Contributor Author

ejk43 commented May 18, 2018

Quick comment: fosphor is working on rfnoc-devel AFAIK

...This is a future-looking fix in case there's ever any item tags attached to an rfnoc RX steam that are not eob indicators (in my case, I add a time tag at the start of each steam and after each eob to maintain timing information).

@mbr0wn mbr0wn merged commit 51e8828 into EttusResearch:master Aug 21, 2018
@mbr0wn
Copy link
Contributor

mbr0wn commented Aug 21, 2018

Thanks for the fix. Should have merged this ages ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants