Allowing to disable the sending of end of burst packet #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbr0wn
reviewed
Mar 7, 2019
include/ettus/rfnoc_block_impl.h
Outdated
| @@ -74,7 +74,8 @@ namespace gr { | |||
| const device3::sptr &dev, | |||
| const std::string &block_id, | |||
| const ::uhd::stream_args_t &tx_stream_args, | |||
| const ::uhd::stream_args_t &rx_stream_args | |||
| const ::uhd::stream_args_t &rx_stream_args, | |||
| const bool end_of_burst_enabled = true | |||
There was a problem hiding this comment.
I think this name is misleading. How about enable_eob_on_stop?
Reason being, this made me take another look at this code, and we should be honoring EOBs in the TX functions, but we don't. Let's assume that we did, then this argument would imply that all EOBs are disabled, but we only want to disable EOBs on stop().
There was a problem hiding this comment.
Hey @mbr0wn ,
That makes sense, I honestly did not think of things from that perspective. I have updated the name accordingly.
|
Thank you so much! Manually merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For certain use cases of RFNoC blocks the data expected by the block is only in terms of streams. This is the case by default while using AXI Wrappers' simple mode when the user does not intend to interact with the headers of the packets and is concerned only with the payload of the packets.
In such applications when the user is not intending to use the headers an additional packet that is sent as the end of burst produces unexpected results. The situation is worsened upon implementation of state machines that depend on receiving certain number of packets.
The problem can be resolved in hardware block by consuming/ignoring the end of burst packet, but that still results in performing operations that are not relevant to intended designs.
Proposed solution
Testing