Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support the new DPDK LTS 21.11 #547

Closed
cpaelzer opened this issue Jan 13, 2022 · 2 comments
Closed

Please support the new DPDK LTS 21.11 #547

cpaelzer opened this issue Jan 13, 2022 · 2 comments

Comments

@cpaelzer
Copy link
Contributor

Issue Description

Hello UHD project,
I wanted to report a build issue against the new DPDK LTS release 21.11 fails.

/<<PKGBUILDDIR>>/host/lib/include/uhdlib/transport/dpdk/udp.hpp:61:13: warning: "PKT_TX_IP_CKSUM" is deprecated
   61 |     mbuf->ol_flags = PKT_TX_IP_CKSUM | PKT_TX_IPV4;
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/host/lib/include/uhdlib/transport/dpdk/udp.hpp:61:13: warning: "PKT_TX_IPV4" is deprecated
   61 |     mbuf->ol_flags = PKT_TX_IP_CKSUM | PKT_TX_IPV4;
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/host/lib/transport/udp_dpdk_link.cpp: In member function ‘virtual void uhd::transport::udp_dpdk_link::release_send_buff(uhd::transport::frame_buff::uptr)’:
/<<PKGBUILDDIR>>/host/lib/transport/udp_dpdk_link.cpp:173:52: error: ‘struct rte_ether_hdr’ has no member named ‘d_addr’; did you mean ‘dst_addr’?
  173 |         rte_ether_addr_copy(&_remote_mac, &l2_hdr->d_addr);
      |                                                    ^~~~~~
      |                                                    dst_addr
/<<PKGBUILDDIR>>/host/lib/transport/udp_dpdk_link.cpp:174:50: error: ‘struct rte_ether_hdr’ has no member named ‘s_addr’; did you mean ‘dst_addr’?
  174 |         rte_ether_addr_copy(&local_mac, &l2_hdr->s_addr);
      |                                                  ^~~~~~
      |                                                  dst_addr

Full logs for all architectures can be found in this try to rebuild against the new DPDK.

Setup Details and Steps to reproduce

No special setup needed in regard to hardware.
Just try to build it using DPDK 21.11 in Ubuntu 22.04 - right now that means Jammy with proposed enabled.

When building UHD in there it will fail to build as reported.

Additional Information

IMHO we'd need something like this change for 20.11, but to now also include 21.11.

FYI: For now in Ubuntu UHD is on the tail end of the DPDK transition and for now I have to interim-disable DPDK support in those builds to get everything else moving for the upcoming release of Ubuntu 22.04

bluca added a commit to bluca/uhd that referenced this issue Jan 14, 2022
Some APIs were changed with the latest DPDK LTS release,
add some ifdefs to fix the build.

Fixes EttusResearch#547
@manderseck
Copy link
Contributor

Thanks for reporting this issue @cpaelzer. We are aware of that and had an update on our list anyway, so we used the opportunity to leverage PR #548. It still has to go through our internal review process and your issue will be closed automatically as soon as the changes will have been merged into our internal master. A little bit later it will arrive in the public repo, too.

@cpaelzer
Copy link
Contributor Author

cpaelzer commented Jan 20, 2022

Yeah I know about #548 as @bluca is a friend of mine working on DPDK in Debian with me.
Thanks for the interim feedback @manderseck - looking forward to that release then ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants