-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker-sync start when already started raises an exception #695
Comments
I have got the same error since this morning |
Me too |
Same behavior here after the Mac OSX Catalina (
I also noticed some Unison spawn instability with the same configuration (with
|
Despite :sync_name being a string type argument, in Mac OS X / a few versions of Ruby reported, the argument's value gets interpreted as nil when not given on the command line. This sets the default for the argument to an empty string so that when .empty? is called on it, it won't produce NoMethodError the way it would for nil
I am convinced I have found the cause of the issue: The value is expected to default to an empty string (ostensibly) but it's coming through as nil for whatever reason. PR #698 addresses this by explicitly setting a default. Edit: there were other issues that came up when I set the default explicitly, so I modified my PR to address the specific exception that arose (i.e. check for whether the value is |
This makes pretty much sense -this was introduced in the last release and we forgot to care about the proper defaults. Thanks for your effort |
Thank you @Deconstrained for your work and @EugenMayer for the new |
The main driving force is the community right now, I just take time to coordinate / stuff together. So I forward all the credits to you gents and lads :) |
Error
When you run
docker-sync start
and the sync is already running, you get an error:In the earlier version, if you called
docker-sync start
when it was already running, it would respond with "Sync already running" (or something like that).docker-sync version
0.5.13
Docker Driver
N/A
Sync strategy
N/A
your docker-sync.yml
N/A
OS
MacOS 10.14.6
The text was updated successfully, but these errors were encountered: