Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Monit to auto restart if CPU usage high in Native OSX strategy #521

Merged
merged 4 commits into from
Jan 24, 2018

Conversation

ricmatsui
Copy link
Contributor

@ricmatsui ricmatsui commented Jan 22, 2018


  • monit_enable - Control if monit is used, default false
  • monit_interval - How often in seconds monit performs check, default 5
  • monit_high_cpu_cycles - How many cycles of monit checks need to have high cpu usage (>50%) to trigger a restart, default 2

@EugenMayer
Copy link
Owner

@ricmatsui great contribution, thats really awesome! Could you please update the docs also, that means

https://github.com/EugenMayer/docker-sync/wiki/2.-Configuration
and in parallel https://github.com/EugenMayer/docker-sync/blob/master/example/docker-sync.yml

It would be great to have one monit example in the boilerplate, what do you think? https://github.com/EugenMayer/docker-sync-boilerplate

I also would like to have a advanced topic on https://github.com/EugenMayer/docker-sync/wiki about that - i created https://github.com/EugenMayer/docker-sync/wiki/native_OSX-advanced---monitoring

Could you write some lines about why this is useful, what it does and link to the configuration? That would be awesome.

@ricmatsui
Copy link
Contributor Author

@EugenMayer Thanks, I have added the docs now in those locations and here's an example, too: EugenMayer/docker-sync-boilerplate#11

@EugenMayer
Copy link
Owner

great, that's really well done. last topic to discuss is the default, right now it's on. I would suggest not doing that for now, or we would be forced to release a new minor... that would delay that feature. in addition we do not have a wide field test yet and we do not really now which cycles are a sane 'mass compatibile' value, with possible tradeoffs on reaction time but for all (anybody can adjust those for quicker reaction and faster cleanup). I pledge for not being on by default for the 0.5.x series, but becoming on by default with 0.6

what are your thoughts on this gentleman?

@ricmatsui
Copy link
Contributor Author

@EugenMayer Yeah that makes sense, it'll be good to get wider testing sooner. I have switched to off by default in the PRs and docs now!

@EugenMayer
Copy link
Owner

that's great, this is a long awaited addition to docker-sync, thank you for working your way through that!

I will release this in the next few days with 0.5.3 - any concerns?

@ricmatsuitile
Copy link

@EugenMayer No problem, thanks for pushing this out! Sounds great.

@EugenMayer EugenMayer merged commit d88c4f3 into EugenMayer:master Jan 24, 2018
@EugenMayer EugenMayer added this to the 0.5.3 milestone Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants