fixed #7727 - allow hiding individual profiles from the selector

Eugeny · Jun 4, 2023 · c983743 · c983743
1 parent e813133
commit c983743
Show file tree

Hide file tree

Showing 4 changed files with 55 additions and 8 deletions.
diff --git a/tabby-core/src/configDefaults.yaml b/tabby-core/src/configDefaults.yaml
@@ -48,6 +48,7 @@ enableExperimentalFeatures: false
 pluginBlacklist: []
 commandBlacklist: []
 providerBlacklist: []
+profileBlacklist: []
 hacks:
   disableGPU: false
   disableVibrancyWhileDragging: false

diff --git a/tabby-core/src/services/profiles.service.ts b/tabby-core/src/services/profiles.service.ts
@@ -153,6 +153,8 @@ export class ProfilesService {
 
                 profiles = profiles.filter(x => !x.isTemplate)
 
+                profiles = profiles.filter(x => x.id && !this.config.store.profileBlacklist.includes(x.id))
+
                 options = [...options, ...profiles.map((p): SelectorOption<void> => ({
                     ...this.selectorOptionForProfile(p),
                     weight: p.isBuiltin ? 2 : 1,

diff --git a/tabby-settings/src/components/profilesSettingsTab.component.pug b/tabby-settings/src/components/profilesSettingsTab.component.pug
@@ -70,17 +70,47 @@ ul.nav-tabs(ngbNav, #nav='ngbNav')
                                     button.btn.btn-link.hover-reveal.ms-1((click)='$event.stopPropagation(); launchProfile(profile)')
                                         i.fas.fa-play
 
-                                    button.btn.btn-link.hover-reveal.ms-1((click)='$event.stopPropagation(); newProfile(profile)')
-                                        i.fas.fa-copy
-
-                                    button.btn.btn-link.hover-reveal.ms-1(
-                                        *ngIf='!profile.isBuiltin',
-                                        (click)='$event.stopPropagation(); deleteProfile(profile)'
-                                    )
-                                        i.fas.fa-trash-alt
+                                    .ms-1.hover-reveal(ngbDropdown, placement='bottom-right top-right auto')
+                                        button.btn.btn-link.ms-1(
+                                            ngbDropdownToggle,
+                                            (click)='$event.stopPropagation()'
+                                        )
+                                            i.fas.fa-fw.fa-ellipsis-vertical
+                                        div(ngbDropdownMenu)
+                                            button.dropdown-item(
+                                                ngbDropdownItem,
+                                                (click)='$event.stopPropagation(); newProfile(profile)'
+                                            )
+                                                i.fas.fa-fw.fa-copy
+                                                span(translate) Duplicate
+
+                                            button.dropdown-item(
+                                                ngbDropdownItem,
+                                                *ngIf='profile.id && !isProfileBlacklisted(profile)',
+                                                (click)='$event.stopPropagation(); blacklistProfile(profile)'
+                                            )
+                                                i.fas.fa-fw.fa-eye-slash
+                                                span(translate) Hide
+
+                                            button.dropdown-item(
+                                                ngbDropdownItem,
+                                                *ngIf='profile.id && isProfileBlacklisted(profile)',
+                                                (click)='$event.stopPropagation(); unblacklistProfile(profile)'
+                                            )
+                                                i.fas.fa-fw.fa-eye
+                                                span(translate) Show
+
+                                            button.dropdown-item(
+                                                *ngIf='!profile.isBuiltin',
+                                                (click)='$event.stopPropagation(); deleteProfile(profile)'
+                                            )
+                                                i.fas.fa-fw.fa-trash-alt
+                                                span(translate) Delete
 
                                     .ms-1(class='badge text-bg-{{getTypeColorClass(profile)}}') {{getTypeLabel(profile)}}
 
+                                    .ms-1.text-danger.fas.fa-eye-slash(*ngIf='isProfileBlacklisted(profile)')
+
     li(ngbNavItem)
         a(ngbNavLink, translate) Advanced
         ng-template(ngbNavContent)

diff --git a/tabby-settings/src/components/profilesSettingsTab.component.ts b/tabby-settings/src/components/profilesSettingsTab.component.ts
@@ -297,4 +297,18 @@ export class ProfilesSettingsTabComponent extends BaseComponent {
         this.config.store.profileDefaults[provider.id] = model
         await this.config.save()
     }
+
+    blacklistProfile (profile: PartialProfile<Profile>): void {
+        this.config.store.profileBlacklist = [...this.config.store.profileBlacklist, profile.id]
+        this.config.save()
+    }
+
+    unblacklistProfile (profile: PartialProfile<Profile>): void {
+        this.config.store.profileBlacklist = this.config.store.profileBlacklist.filter(x => x !== profile.id)
+        this.config.save()
+    }
+
+    isProfileBlacklisted (profile: PartialProfile<Profile>): boolean {
+        return profile.id && this.config.store.profileBlacklist.includes(profile.id)
+    }
 }