Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pane navigation improvements #6465

Merged
merged 2 commits into from May 21, 2022
Merged

Pane navigation improvements #6465

merged 2 commits into from May 21, 2022

Conversation

attet
Copy link
Contributor

@attet attet commented May 19, 2022

Hi there, thanks for creating such a great terminal!

In case you think these might be useful for others as well, I added hotkeys for navigating to specific panes and a 'focus follows mouse' -option. Both unassigned/off by default but they work very well for me.

@Eugeny
Copy link
Owner

Eugeny commented May 19, 2022

Wow, thanks for the PR - looks great! My only nitpick is that the hotkey definitions should use ICU plurals so that translators don't have to translate them 10 times :) - like here: https://github.com/Eugeny/tabby/blob/master/tabby-core/src/hotkeys.ts#L69

GitHub
A terminal for a more modern age. Contribute to Eugeny/tabby development by creating an account on GitHub.

@attet
Copy link
Contributor Author

attet commented May 20, 2022

Wow, thanks for the PR - looks great! My only nitpick is that the hotkey definitions should use ICU plurals so that translators don't have to translate them 10 times :) - like here: https://github.com/Eugeny/tabby/blob/master/tabby-core/src/hotkeys.ts#L69

GitHub**tabby/hotkeys.ts at master · Eugeny/tabby**A terminal for a more modern age. Contribute to Eugeny/tabby development by creating an account on GitHub.

Thanks, fixed.

GitHub
A terminal for a more modern age. Contribute to Eugeny/tabby development by creating an account on GitHub.

@Eugeny Eugeny merged commit a96a9ea into Eugeny:master May 21, 2022
@Eugeny
Copy link
Owner

Eugeny commented May 21, 2022

@allcontributors please add @attet for code

@allcontributors
Copy link
Contributor

@Eugeny

I've put up a pull request to add @attet! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants