Save downloaded config (fix #6694) #6885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find, much appreciated! @allcontributors please add @giejqf for code |
|
I've put up a pull request to add @giejqf! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The downloaded config may fail to be saved because of a race condition in writeConfigDataFromSync().
Inside this function, the first line
await this.platform.saveConfig(yaml.dump(data))performs the save action in an async way (ipcRenderer.send / ipcMain.on). It is possible that the new config is not saved before invokingawait this.config.load(), causing it to load the old config and then override the config file inawait this.config.save().This commit replaces (ipcRenderer.send / ipcMain.on) with (ipcRenderer.invoke / ipcMain.handle) to ensure that the new config is saved first.