Improving tabby startup time #8528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested it and it improves my startup time from 2.7s to 2.1s, great work! |
|
Good to hear that ! |
|
Well, I took another look in it to be sure I had done everything I could. But I think we're good for this time. I've just added a new commit to fix a mistake I've made in the placement of the call of the progress bar. |
|
Perfect 👌 |
Perfect 👌 |
Clem-Fern
added a commit
to Clem-Fern/tabby
that referenced
this pull request
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Eugeny,
I found some issues about how tabby can be slow to launch in some case (#6295 , #7390 , #6253 ).
After taking a quick look, I saw that installed plugins are loaded one after another at the app startup.
This PR aim to improve the startup time by finding and loading the plugins
simultaneouslyasynchronously.Startup on latest release with 0 plugins : ~2.9sec
Startup on latest release with 8 plugins : ~3.5sec
Startup on this PR with 0 plugins : ~2.3sec
Startup on this PR with 8 plugins : ~2.3sec
I've only have SSD so there is no huge gab on my side. (Tested on Debian 11, don't have other system on hand sorry :/)
As always, I am not sure theses changes are really relevant nor if it is a good approach to try to reduce the startup time. I hope you could give me a feedback on this when you got time :D