Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win Portable: fix data directory and updater issue #9251

Merged
merged 2 commits into from Nov 19, 2023
Merged

Win Portable: fix data directory and updater issue #9251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2be079a
fix: use data folder on portable app
Clem-Fern Nov 19, 2023
1e096ed
fix: do not use installer to update portable version Eugeny/tabby#7768
Clem-Fern Nov 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/lib/index.ts
View file
Open in desktop
@@ -1,13 +1,15 @@
import { app, ipcMain, Menu, dialog } from 'electron'

// set userData Path on portable version
import './portable'

// set defaults of environment variables
import 'dotenv/config'
process.env.TABBY_PLUGINS ??= ''
process.env.TABBY_CONFIG_DIRECTORY ??= app.getPath('userData')


import 'v8-compile-cache'
import './portable'
import 'source-map-support/register'
import './sentry'
import './lru'
Expand Down
2 changes: 1 addition & 1 deletion tabby-electron/src/services/updater.service.ts
View file
Open in desktop
Expand Up @@ -25,7 +25,7 @@ export class ElectronUpdaterService extends UpdaterService {
super()
this.logger = log.create('updater')

if (process.platform === 'linux') {
if (process.platform === 'linux' || process.env.PORTABLE_EXECUTABLE_FILE) {
this.electronUpdaterAvailable = false
return
}
Expand Down