This repository has been archived by the owner on Jan 22, 2020. It is now read-only.
Adding filter and supporting up/down arrows #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Thank you for the PR! It looks like the 0-9 shortcuts are broken since the list is filtered first, and the index is only checked after that. |
Eugeny
suggested changes
Aug 8, 2019
| @HostListener(`document:keyup`, ['$event']) onKey ($event: KeyboardEvent) { | ||
| if ($event.key >= '0' && $event.key <= '9') { | ||
| let index = $event.key.charCodeAt(0) - '0'.charCodeAt(0) | ||
| this.modalInstance.close(this.items[index]) | ||
| if (index < this.filteredItems.length) { |
There was a problem hiding this comment.
Never happens since the list is always empty after typing a digit in to the filter box
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding filter to quickly search by name and supporting arrows + enter to select item you want more easily