Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate if we can add precommit hook for commiting large files to the repository accidentally #497

Closed
artcz opened this issue Mar 15, 2024 · 0 comments · Fixed by #547
Closed

Investigate if we can add precommit hook for commiting large files to the repository accidentally #497

artcz opened this issue Mar 15, 2024 · 0 comments · Fixed by #547

Comments

@artcz
Copy link
Contributor

artcz commented Mar 15, 2024

This is mostly to check if we don't add big binary files or images.

We can also separately check this on CI.
@egeakman egeakman mentioned this issue Mar 28, 2024
Merged
patrick91 pushed a commit that referenced this issue Apr 3, 2024
@egeakman
Add pre-commit checks and fix its complaints (#547)
8ec69ff 
Closes #497 

We can change the ``maxkb`` argument to our needs.

Added some handy checks as well.

Since we are using [``pre-commit``](https://pypi.org/p/pre-commit), we
might want to add that to a ``requirements-dev.txt``.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pre-commit checks and fix its complaints egeakman/ep-website
1 participant
@artcz