Take empty trains into account when checking for constant pulse pattern #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minor suggestion: I would make the added argument keyword only, for readability. Else LGTM. |
Fair point 🤔 I think I also want to invert the logic, make it |
philsmt
force-pushed
the
feat/pulses-constant-empty-trains
branch
from
bfcb5ee
to
98ca134
Compare
|
Made the argument keyword-only and inverted the logic, will merge tomorrow afternoon if there's no objection. |
|
The change is fine, but it needs a |
|
Why? |
|
Oh right, sorry I misunderstood, NVM then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested via #136 (actually from instrument staff), this PR adds an optional flag to
PulsePattern.is_constant_pattern()to optionally take empty trains into account when determining whether the pulse pattern is content. An empty train will essentially always the pattern to not be constant. To preserve the original API, they continue to be ignored by default.