Move the __repr__() logic into .info() #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I generally try to follow this pattern of having a single line repr and explicit methods to get more detailed info, although I know not everyone agrees. Another option if people don't like that might be to use the IPython special methods to provide a Markdown/HTML repr, which is not used in a container (unless that's changed recently). |
This hasn't happened yet, but one could imagine doing something like putting one of these objects into a list or something and __repr__() completely breaking the pretty-printing. Instead we now recommend using .info() like with DataCollection's.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hasn't happened yet, but one could imagine doing something like putting one of these objects into a list or something and repr() completely breaking the pretty-printing. Instead we now recommend using .info() like with DataCollection's.