Add DldPulses interface for pulse information in reconstructed DLD data #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesWrigley
requested changes
Aug 8, 2023
philsmt
force-pushed
the
feat/dld-pulses
branch
from
452975d
to
cfe9c3c
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First
PulsePatternimplementation based on the new and simpler interface.The offline calibration based REMI/DLD reconstruction adds pulse information to the output files that may be different than the one obtained from timeserver data due to particular configurations chosen for reconstruction at the time. This compoent allows to read this data and expose it via the very same interface.