Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tax haven: market transactions are free #41

Closed
jdhirst opened this issue Apr 4, 2021 · 5 comments
Closed

Tax haven: market transactions are free #41

jdhirst opened this issue Apr 4, 2021 · 5 comments
Labels
bug Something isn't working in progress this bug is being worked on by assigned member.
Milestone

Comments

@jdhirst
Copy link
Contributor

jdhirst commented Apr 4, 2021

From AlasiyaEvE created by ryllae: zhyrohaad/AlasiyaEvE#103

Put a Shuttle up for sale with a 1 day limit. Price it for a Quadrillion ISK. You can list the item without paying the exorbitant broker's fee.

Broker's fees should be charged on all non-immediate orders.

@jdhirst
Copy link
Contributor Author

jdhirst commented Apr 4, 2021

this has been implemented with market code rewrite
skills and standings now affect taxes and fees

@jdhirst
Copy link
Contributor Author

jdhirst commented Apr 4, 2021

Sales tax is not deduced from the amount received on sale either.

These values should be affected by your appropriate Trade skills.

@jdhirst
Copy link
Contributor Author

jdhirst commented Apr 4, 2021

this i am aware of.
part of skill effects was dealing with the non-ship parts, with trade/agents being close to the bottom of the list.
also, as noted in #105, market code is incomplete.

however, you are correct on both accounts: fees should be immediate, and tax is modified by skills.
this will be implemented eventually. ;)

@jdhirst jdhirst added the needs-triage This issue needs to be reviewed for accuracy and details label Apr 4, 2021
@Almamu
Copy link
Contributor

Almamu commented Oct 10, 2021

942d253:
Fixed broker's fees not being calculated correctly.
Fixed sell orders taking the items from the hangar when there was not enough money to pay broker's fee.

@jdhirst jdhirst added bug Something isn't working in progress this bug is being worked on by assigned member. and removed needs-triage This issue needs to be reviewed for accuracy and details labels Oct 11, 2021
@jdhirst jdhirst added this to the 0.8.5 milestone Oct 11, 2021
@jdhirst jdhirst added this to To do in EVEmu Server Development via automation Oct 11, 2021
@jdhirst jdhirst moved this from To do to In progress in EVEmu Server Development Oct 11, 2021
@jdhirst
Copy link
Contributor Author

jdhirst commented Apr 1, 2022

This has been fixed, closing. If further work to tax calculations need to be done, please re-open after release.

@jdhirst jdhirst closed this as completed Apr 1, 2022
EVEmu Server Development automation moved this from In progress to Done Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress this bug is being worked on by assigned member.
Development

No branches or pull requests

2 participants