New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency cleanup #42

Open

wherget wants to merge 5 commits into EvaisaDev:main from wherget:dependency-cleanup

Contributor

wherget commented Jun 29, 2024

This PR tries to minimize dependencies needing to be shipped to reduce the size of the nupkg.

I'd like to highlight that:

DiaSymReader isn't needed (anymore), which alleviates the need for the Azure nuget repository
It can be easily replaced by on of its direct dependencies (System.Reflection.Metadata), whose version that was previously used indirectly had been deprecated. Bumped to a current-ish release.
It should be enough to build the CodeGen Part of the Netcode Editor package, Editor custom components are of little use to us here.

Caveats:

I'm not sure how well the DEVELOPMENT_BUILD define for the Netcode library holds up across versions. It did for all 2-ish that I tested
I've not actually checked across the entirety of the matrix build locally if "it compiles" implies "it works". 😅

wherget added 5 commits

June 29, 2024 16:32


          also resolve from nuget proper (for Microsoft.Build.Utilities.Core)

77bd77e


          remove unused Microsoft.DiaSymReader.Converter dependency

715149c


          only link NetCode.Editor.CodeGen directory for NetcodePatcher

4efa88e


          remove unused UnityEditor dependencies

c6c9f0d


          cleanup dependencies

ed500f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment