Update length of month and year #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since leap years are actually every four years EXCEPT every 100 years but INCLUDING every four-hundred years, the actual number of days in a year is 365.2425 not 365.25. This means that the number of days in a month is (on average) 30.436875 days. This means we have to update all the test data to conform to the correct calculations.
|
Mentioned some concerns in #156—let's discuss there unless it's about this fix specifically. |
|
Would be nice to merge it, thanks @IDisposable for the work and @EvanHahn for the repo |
|
For anyone following along here but not in the original issue, I added a comment explaining my plans here. |
|
I just renamed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since leap years are actually every four years EXCEPT every hundred years but INCLUDING every four-hundred years, the average number of days in a year is
365.2425not365.25. This means that the number of days in a month is (on average)30.436875days.This means we have to update all the test data to conform to the correct calculations.
Fixes #156