Merge pull request #913 from EvanHerman/sanitize-values

Escape and sanitize form data
EvanHerman · Jun 12, 2023 · 53dfbbc · 53dfbbc
2 parents 74c8030 + 71b8d57
commit 53dfbbc
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/admin/class-yikes-inc-easy-mailchimp-extender-admin.php b/admin/class-yikes-inc-easy-mailchimp-extender-admin.php
@@ -543,20 +543,20 @@ public function yikes_easy_mailchimp_display_review_us_notice() {
 
 				// The URL of the page the user is currently on
 				$current_uri  	  = isset( $_SERVER['REQUEST_URI'] ) && ! empty( $_SERVER['REQUEST_URI'] ) ? $_SERVER['REQUEST_URI'] : false;
-				$current_host	  = isset( $_SERVER['HTTP_HOST'] ) && ! empty( $_SERVER['HTTP_HOST'] ) ? $_SERVER['HTTP_HOST'] : false;
+				$current_host	    = isset( $_SERVER['HTTP_HOST'] ) && ! empty( $_SERVER['HTTP_HOST'] ) ? $_SERVER['HTTP_HOST'] : false;
 				$current_protocol = is_ssl() === true ? 'https://' : 'http://';
-				$current_url	  = ( $current_uri !== false && $current_host !== false ) ? $current_protocol . $current_host . $current_uri : admin_url();
+				$current_url	    = ( $current_uri !== false && $current_host !== false ) ? $current_protocol . $current_host . $current_uri : admin_url();
 
 				$plugin_name = '<strong>Easy Forms for Mailchimp</strong>';
 				// Review URL - Change to the URL of your plugin on WordPress.org.
-				$reviewurl = 'https://wordpress.org/support/view/plugin-reviews/yikes-inc-easy-mailchimp-extender';
-				$addons_url = esc_url( admin_url( 'admin.php?page=yikes-inc-easy-mailchimp-addons' ) );
-				$nobugurl = esc_url_raw( add_query_arg( 'yikes_easy_mc_icons_nobug', '1', $current_url ) );
+				$reviewurl   = 'https://wordpress.org/support/view/plugin-reviews/yikes-inc-easy-mailchimp-extender';
+				$addons_url  = esc_url( admin_url( 'admin.php?page=yikes-inc-easy-mailchimp-addons' ) );
+				$nobugurl    = esc_url_raw( add_query_arg( 'yikes_easy_mc_icons_nobug', '1', $current_url ) );
 
 				// Make sure all of our variables have values.
 				$reviewurl  = ( ! empty( $reviewurl ) ) ? $reviewurl : '';
 				$addons_url = ( ! empty( $addons_url ) ) ? $addons_url : '';
-				$nobugurl	= ( ! empty( $nobugurl ) ) ? $nobugurl : '';
+				$nobugurl   = ( ! empty( $nobugurl ) ) ? $nobugurl : '';
 
 				$review_message = '<div id="yikes-mailchimp-logo"></div>';
 				$review_message .= sprintf(
@@ -1359,17 +1359,17 @@ public function generate_manage_forms_sidebar( $lists ) {
 							if ( ! empty( $lists ) ) {
 								foreach( $lists as $mailing_list ) {
 									?>
-									<option value="<?php echo $mailing_list['id']; ?>"><?php echo stripslashes( $mailing_list['name'] ) . ' (' . $mailing_list['stats']['member_count'] . ') '; ?></option>
+									<option value="<?php echo esc_attr( $mailing_list['id'] ); ?>"><?php echo esc_html( $mailing_list['name'] ) . ' (' . esc_html( $mailing_list['stats']['member_count'] ) . ') '; ?></option>
 									<?php
 								}
 							} else {
 								if ( get_option( 'yikes-mc-api-validation', 'invalid_api_key' ) == 'invalid_api_key' ) {
 									?>
-									<option><?php echo __( "Please enter a valid API key." , 'yikes-inc-easy-mailchimp-extender' ); ?></option>
+									<option><?php _e( "Please enter a valid API key." , 'yikes-inc-easy-mailchimp-extender' ); ?></option>
 									<?php
 								} else {
 									?>
-									<option><?php echo __( "No lists were found on the account." , 'yikes-inc-easy-mailchimp-extender' ); ?></option>
+									<option><?php _e( "No lists were found on the account." , 'yikes-inc-easy-mailchimp-extender' ); ?></option>
 									<?php
 
 								}
@@ -2462,8 +2462,8 @@ public function yikes_easy_mailchimp_create_form() {
 
 			$result = $this->form_interface->create_form( array(
 				'list_id'          => sanitize_key( $_POST['associated-list'] ),
-				'form_name'        => stripslashes( $_POST['form-name'] ),
-				'form_description' => stripslashes( $_POST['form-description'] ),
+				'form_name'        => sanitize_text_field( $_POST['form-name'] ),
+				'form_description' => sanitize_text_field( $_POST['form-description'] ),
 			) );
 
 			// if an error occurs during the form creation process
@@ -2599,7 +2599,7 @@ public function yikes_easy_mailchimp_update_form() {
 
 			// Store our values!
 			$list_id                 = $_POST['associated-list'];
-			$form_name               = stripslashes( $_POST['form-name'] );
+			$form_name               = sanitize_text_field( $_POST['form-name'] );
 			$form_description        = sanitize_text_field( stripslashes( $_POST['form-description'] ) );
 			$redirect_user_on_submit = $_POST['redirect-user-on-submission'];
 			$redirect_page           = $_POST['redirect-user-to-selection'];

diff --git a/admin/partials/edit-form.php b/admin/partials/edit-form.php
@@ -5,7 +5,7 @@
 if ( isset( $_GET['sql_error'] ) ) {
 
 	if ( get_option( 'yikes-mailchimp-debug-status', '' ) === '1' ) {
-		wp_die( '<strong>' . __( 'Error Creating Form', 'yikes-inc-easy-mailchimp-extender' ) . '</strong> <p>' . stripslashes( urldecode( $_GET['sql_error'] ) ) . '</p>' . __( 'Error Creating Form', 'yikes-inc-easy-mailchimp-extender' ) );
+		wp_die( '<strong>' . __( 'Error Creating Form', 'yikes-inc-easy-mailchimp-extender' ) . '</strong> <p>' . esc_html( urldecode( $_GET['sql_error'] ) ) . '</p>' . __( 'Error Creating Form', 'yikes-inc-easy-mailchimp-extender' ) );
 	} else {
 		wp_die( '<strong>' . __( 'Error Creating Form', 'yikes-inc-easy-mailchimp-extender' ) . '</strong><p>' . __( "Please try again. If the error persists please get in contact with the YIKES Inc. support team.", 'yikes-inc-easy-mailchimp-extender' ) . '</p>' );
 	}