Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] v2.6.0 下 head_end 位置的 injector，实际注入的位置在 body #321

Closed
3 tasks done
bianyukun1213 opened this issue Dec 14, 2023 · 3 comments
Closed
3 tasks done

[BUG] v2.6.0 下 head_end 位置的 injector，实际注入的位置在 body #321

bianyukun1213 opened this issue Dec 14, 2023 · 3 comments
Assignees
@EvanNotFound
Labels
bug Something isn't working dev:finished Development in dev branch completed. Please wait for the new version to release

Comments

@bianyukun1213
Copy link

提交 Issue 前检查清单

Bug 描述

不太确定是不是 Redefine 的 bug，但我测试新建一博客使用默认的 landscape 主题或 Redefine v2.5.6 无此问题，切换到 Redefine v2.6.0，就出问题。

我使用 Hexo 的注入器（injector）实现一些自定义的功能。根据文档，head_end 位置的注入器应该将代码注入到 </head> 前，但在 Redefine v2.6.0 下，代码被注入到 body。

复现方法

编写一个 head_end 位置的 injector，在 Redefine v2.6.0 下观察注入效果。

预期结果

注入的内容在 </head> 前。

截图

No response

电脑操作系统

Windows

浏览器

Mozilla Firefox、Microsoft Edge

版本

120.0.1、120.0.22

移动端设备

No response

移动端操作系统

No response

浏览器

No response

版本

No response

其他

No response
@bianyukun1213 bianyukun1213 added the bug Something isn't working label Dec 14, 2023
@bianyukun1213
Copy link
Author

应该跟 preloader 有关系。我在网络请求里看到的是正常的 HTML，检视元素时就变了；然后关闭 preloader，检视元素时也正常了。

@bianyukun1213
Copy link
Author

bianyukun1213 commented Dec 16, 2023 •
edited

似乎是环境问题。

@bianyukun1213 bianyukun1213 reopened this Dec 16, 2023
EvanNotFound added a commit that referenced this issue Jan 28, 2024
@EvanNotFound
feat: fix head inject in body after enabling preloader #321
8b32836
@EvanNotFound EvanNotFound added the dev:finished Development in dev branch completed. Please wait for the new version to release label Jan 28, 2024
@EvanNotFound EvanNotFound mentioned this issue Feb 5, 2024
Merged
@EvanNotFound
Copy link
Owner

已在 Redefine v2.6.1 版本修复，请前往 https://github.com/EvanNotFound/hexo-theme-redefine/releases 查看并更新主题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvanNotFound EvanNotFound

Labels
bug Something isn't working dev:finished Development in dev branch completed. Please wait for the new version to release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bianyukun1213 @EvanNotFound