Remove unnecessary Mode

installer/installer.go

@@ -70,12 +70,11 @@ func InstallDotfile(dotfile *PreparedDotfile, config InstallConfig) error {
 		return os.Remove(installPath)
 	}
 
-	targetMode := dotfile.Permissions.New | dotfile.Mode.New
+	targetMode := dotfile.Permissions.New
 
 	// Only filemode differs
 	modeChanged := !dotfile.IsNew &&
-		!dotfile.ContentsDiffer &&
-		(dotfile.Permissions.IsChanged() || dotfile.Mode.IsChanged())
+		!dotfile.ContentsDiffer && dotfile.Permissions.IsChanged()
 
 	if modeChanged {
 		return os.Chmod(installPath, targetMode)

installer/prepare.go

@@ -36,11 +36,6 @@ type PreparedDotfile struct {
 	// compiled or installed.
 	SourcesAreIrregular bool
 
-	// Mode represents the change in the file mode bits of the source and
-	// target os.FileMode (does not include permissions). This will not be set
-	// if the sources are irregular.
-	Mode FileMode
-
 	// Permissions represents the change in permission between the compiled source
 	// and the currently installed dotfile. Equal permissions can be verified
 	// by calling Permissions.IsSame.
@@ -67,7 +62,7 @@ type PreparedDotfile struct {
 // IsChanged reports if the prepared dotfile has changes from the target
 // dotfile.
 func (p *PreparedDotfile) IsChanged() bool {
-	return p.IsNew || p.Added || p.Removed || p.ContentsDiffer || p.Permissions.IsChanged() || p.Mode.IsChanged()
+	return p.IsNew || p.Added || p.Removed || p.ContentsDiffer || p.Permissions.IsChanged()
 }
 
 // FileMode represents the new and old dotfile file mode.
@@ -165,17 +160,10 @@ func PrepareDotfiles(dotfiles resolver.Dotfiles, config config.SourceConfig) Pre
 			Old: targetMode & os.ModePerm,
 			New: sourcePermissions,
 		}
-		prepared.SourcePermissionsDiffer = tookLowest
 
+		prepared.SourcePermissionsDiffer = tookLowest
 		prepared.SourcesAreIrregular = !isAllRegular(sourceInfo)
 
-		if len(sourceInfo) > 0 && !prepared.SourcesAreIrregular {
-			prepared.Mode = FileMode{
-				Old: targetMode &^ os.ModePerm,
-				New: sourceInfo[0].Mode() &^ os.ModePerm,
-			}
-		}
-
 		// Nothing needs to be verified if the dotfile is being added or removed.
 		if !exists || dotfile.Removed {
 			return

output/logger.go

@@ -150,12 +150,12 @@ func (l *Output) DotfileInfo(dotfile *installer.PreparedDotfile) {
 		)
 	}
 
+	fmt.Println()
+
 	ln := func(v ...interface{}) {
 		fmt.Printf("   %s %s\n", v...)
 	}
 
-	fmt.Println()
-
 	if dotfile.PrepareError != nil {
 		ln(e, color.HiRedString(dotfile.PrepareError.Error()))
 	}