Treat source irregularity as errors

installer/installer.go

@@ -1,7 +1,6 @@
 package installer
 
 import (
-	"fmt"
 	"io"
 	"os"
 	"path"
@@ -57,10 +56,6 @@ func InstallDotfile(dotfile *PreparedDotfile, config InstallConfig) error {
 		installPath = config.OverrideInstallPath + separator + dotfile.Path
 	}
 
-	if dotfile.SourcesAreIrregular {
-		return fmt.Errorf("Source files are not all regular files")
-	}
-
 	if !dotfile.IsChanged() && !config.ForceReinstall {
 		return nil
 	}

installer/prepare.go

@@ -1,6 +1,7 @@
 package installer
 
 import (
+	"fmt"
 	"os"
 	"sync"
 
@@ -164,6 +165,10 @@ func PrepareDotfiles(dotfiles resolver.Dotfiles, config config.SourceConfig) Pre
 		prepared.SourcePermissionsDiffer = tookLowest
 		prepared.SourcesAreIrregular = !isAllRegular(sourceInfo)
 
+		if prepared.SourcesAreIrregular {
+			prepared.PrepareError = fmt.Errorf("Source files are not all regular files")
+		}
+
 		// Nothing needs to be verified if the dotfile is being added or removed.
 		if !exists || dotfile.Removed {
 			return

output/logger.go

@@ -160,10 +160,6 @@ func (l *Output) DotfileInfo(dotfile *installer.PreparedDotfile) {
 		ln(e, color.HiRedString(dotfile.PrepareError.Error()))
 	}
 
-	if dotfile.SourcesAreIrregular {
-		ln(e, "source files are irregular")
-	}
-
 	if dotfile.OverwritesExisting {
 		ln(w, "ovewriting existing file")
 	}