Fix unnamed append points #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `ConfigFile.compile()`, the variable `content` is used but not initialized, which results in unnamed append points being deleted and `insert_lines` being appended at the end instead. Due to the undifferentiated `try/except` block around this, the error is silently ignored. This fix makes the `try/except` block only handle `ValueError`, which would occur when there's no explicit append point.
evanpurkhiser
added a commit
that referenced
this pull request
Jun 3, 2014
Fix unnamed append points
|
Good catch, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ConfigFile.compile(), the variablecontentis used but notinitialized, which results in unnamed append points being deleted and
insert_linesbeing appended at the end instead. Due to theundifferentiated
try/exceptblock around this, the error is silentlyignored.
This fix makes the
try/exceptblock only handleValueError, whichwould occur when there's no explicit append point.