build: Fix webpack-plugin-serve prod warnings

evanpurkhiser · Jan 18, 2021 · b4f5bc4 · b4f5bc4 · vercel · Jan 18, 2021
1 parent cfad37c
commit b4f5bc4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/webpack.config.base.ts b/webpack.config.base.ts
@@ -14,6 +14,9 @@ const envConfig = {
   COMMIT: commit,
 };
 
+export const withWebpackPluginServe = (appList: string[]) =>
+  [...appList, IS_PROD ? '' : 'webpack-plugin-serve/client'].filter(s => s !== '');
+
 export const baseConfig: webpack.Configuration = {
   mode: IS_PROD ? 'production' : 'development',
   watch: process.env.NODE_ENV !== 'production',

diff --git a/webpack.config.renderer.ts b/webpack.config.renderer.ts
@@ -7,7 +7,7 @@ import {WebpackPluginServe} from 'webpack-plugin-serve';
 
 import path from 'path';
 
-import {baseConfig} from './webpack.config.base';
+import {baseConfig, withWebpackPluginServe} from './webpack.config.base';
 
 const serve = new WebpackPluginServe({
   port: 2003,
@@ -21,7 +21,7 @@ const serve = new WebpackPluginServe({
 const rendererConfig: webpack.Configuration = merge(baseConfig, {
   target: 'electron-renderer',
   entry: {
-    app: ['./src/renderer/app.tsx', 'webpack-plugin-serve/client'],
+    app: withWebpackPluginServe(['./src/renderer/app.tsx']),
   },
   optimization: {minimize: false},
   module: {

diff --git a/webpack.config.website.ts b/webpack.config.website.ts
@@ -7,11 +7,11 @@ import {WebpackPluginServe} from 'webpack-plugin-serve';
 
 import path from 'path';
 
-import {baseConfig} from './webpack.config.base';
+import {baseConfig, withWebpackPluginServe} from './webpack.config.base';
 
 const websiteConfig: webpack.Configuration = merge(baseConfig, {
   entry: {
-    app: ['./src/website/app.tsx', 'webpack-plugin-serve/client'],
+    app: withWebpackPluginServe(['./src/website/app.tsx']),
   },
   output: {
     path: path.resolve(__dirname, 'dist/website'),