fix: broken link

[vimode]

Fixes #217

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
portfolio-ideas	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Jan 20, 2023 at 2:50PM (UTC)

[github-actions]

Hello @vimode, 🔥 thanks for raising a pull request in this project. Now, sit back and drink some coffee while we review this.

[Evavic44]

LGTM 👍🏽

[vimode]

Thank you @Evavic44

The same issue exists in portfolio.md
I assumed updating README should also update the same at portfolio.md but it seems like that didn't happen.

Should I make a new PR to update portfolio.md?

[Evavic44]

Hey, @vimode Your changes didn't reflect because we're using an npm command to copy the content of the README.md file to Portfolio.md whenever a change is made.

But this will only work when you make the changes from within your editor and not the Github GUI.

Essentially, running:

npm run deploy

should make the updates, and then another PR can be raised. It's kinda tedious, I know. Which is why it isn't specified on the contributing guidelines.

Though I'm thinking it may be a good idea to do so for contributors who have the same question.

[vimode]

Understood. I will make a PR with the updated deployed version.

.... Which is why it isn't specified on the contributing guidelines.
Though I'm thinking it may be a good idea to do so for contributors who have the same question

The current Contributing guidelines encourages usage of the Github web interface to update the README and add the new portfolios which I assume is to encourage people to easily contribute, especially for beginners.

So adding the information about updating the deployment might require changing the contributing guidelines completely. As it would not make much sense for the contributor to use the Github web interface to make the changes as they still need to make changes locally.

An alternative solution could be to setup github actions to run npm run deploy when the changes are merged?

[Evavic44]

Understood. I will make a PR with the updated deployed version.

.... Which is why it isn't specified on the contributing guidelines.
Though I'm thinking it may be a good idea to do so for contributors who have the same question

The current Contributing guidelines encourages usage of the Github web interface to update the README and add the new portfolios which I assume is to encourage people to easily contribute, especially for beginners.

So adding the information about updating the deployment might require changing the contributing guidelines completely. As it would not make much sense for the contributor to use the Github web interface to make the changes as they still need to make changes locally.

An alternative solution could be to setup github actions to run npm run deploy when the changes are merged?

GitHub actions might be a viable option. If you can, raise an issue so we discuss this further. Thanks