Fix issue with large messages over network connection #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvenAR
changed the title
Fixes #91 When using a networked connection, large SimConnect messages (e.g. facilities lists) are most likely to be split into multiple TCP packets/chunks. The old code assume that `Socket.read(<len>)` blocks until the full <len> is received - which is not the case. The new code will put all received data in a buffer and wait for it to become long enough before trying to parse the data.
EvenAR
force-pushed
the
fix-socket-issues
branch
from
5dc7af2
to
27bc4c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach for fixing #91 (see #92)
When using a networked connection, large SimConnect messages (e.g. facilities lists) are most likely to be split into multiple TCP packets/chunks. The old code assume that
Socket.read(<len>)blocks until the full<len>is received - which is not the case. The new code will put all received data in a buffer and wait for it to become long enough before trying to parse it as a SimConnect message.