-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental Refactoring #261
base: master
Are you sure you want to change the base?
Incremental Refactoring #261
Conversation
With given changes the performance of wildcard version doubled, but ordinary emitter's performance decreased. This is because I temporary removed many micro optimizations that made it hard to refactor the code. I plan to add them back at some point.
|
Will the PR being continued? |
Yeah, I am interested in continuing, but It's important to discuss changes. The project is much depended upon, changes I have proposed so far are massive. Long story short: need feedback. |
I found out that many methods exist actually in 2 different implementations: for wildcard emitter and classic one, but for no reason got merged into single function. I am going to:
I am starting this PR to show progress in real time and also discuss these changes. I don't insist on merging, but if you find this useful, it would be great.