Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set ETIMEDOUT code on timeout exception #268

Merged
merged 1 commit into from
Sep 29, 2020
Merged

set ETIMEDOUT code on timeout exception #268

merged 1 commit into from
Sep 29, 2020

Conversation

splitice
Copy link
Contributor

Small change that makes the timeout exception behave similarly to other libraries (e.g Q) by providing an error code on the exception.

DigitalBrainJS
DigitalBrainJS approved these changes Sep 29, 2020
View reviewed changes
Copy link
Collaborator

@DigitalBrainJS DigitalBrainJS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. It's a reasonable change. Thank you!

@DigitalBrainJS DigitalBrainJS merged commit 90a37aa into EventEmitter2:master Sep 29, 2020
@splitice
Copy link
Contributor Author

Thanks @DigitalBrainJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DigitalBrainJS DigitalBrainJS DigitalBrainJS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@splitice @DigitalBrainJS