Add Event before the loading of the plugins. #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds EventGhost.Started event to take place before the running of the Autostart macro. This is done so that if the user needs to set into place any globals that a script may depend on it can be done before the possibility of a plugin starting and generating an event before the Main.OnInit gets triggered. There is a payload with this event that is an instance of a Time(datetime.datetime) object I subclassed the datetime.datetime class to override the __str__ and __repr__ methods so it would produce a nice date in the log. other then that it functions exactly the same as a datetime.datetime object
Correction: event name is EventGhost.Startup Removed subclassing of the datetime.datetime object as this caused some issues. The object returned is a class that stores the datetime.datetime instance and will returns any attributes to has correctly other then __repr__ and __str__ I also removed adding the execution of the event into the action thread. The Autostart.Execute() was already being run in the action thread. and this caused a hang because it would wait for the event to get run when the Execute was already being run.
kdschlosser
changed the title
kdschlosser
changed the title
topic2k
reviewed
Oct 21, 2017
eg/Classes/AutostartItem.py
Outdated
| t_fmt = t_fmt.format('th') | ||
| else: | ||
| t_fmt = t_fmt.format( | ||
| ["st", "nd", "rd"][t.tm_mday % 10 - 1] |
There was a problem hiding this comment.
NameError: global name 't' is not defined
Should t.tm_mday be self._datetime.day?
There was a problem hiding this comment.
could be let me look at the code. i could have messed it up somehow. tho i did test it and it worked. maybe i missed the error when it happened.
|
OK sir. I have fixed the traceback issue. |
topic2k
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds EventGhost.Startup event to take place before the running of the Autostart macro. This is done so that if the user needs to set into place any globals that a script may depend on it can be done before the possibility of a plugin starting and generating an event before the Main.OnInit gets triggered.
There is a payload with this event that is an instance of an AutostartItem.Time() object. I stored a datetime.datetime object and it returns all methods/attributes correctly except str and repr methods so it would produce a nice date in the log.
example: EventGhost.Startup Saturday, October 14th, 2017 @ 01:56:46 AM