/ eventsource Public
Fix unicode chunking issue #108
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
If you send a message with unicode characters which ends up being split into two chunks on the receiving end, the text will be garbled because we are simply concatenating to a string.
I had to implement a fix for this quickly and publish it to an internal branch and couldn't (quickly) figure out how to modify the current code to be unicode safe, so I reimplemented the streaming/parsing using some higher-level modules that I find makes stream handling easier (through, split and pump).
I realize this adds dependencies to an otherwise nearly dependency-free project, so I'd be happy if anyone would take a look at an alternative solution. Still raising this as a PR to show the issue in question, and I've also added some tests to reproduce the issue.