Fix Default Keep Alive #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskardudycz
reviewed
Feb 12, 2021
thefringeninja
force-pushed
the
keep-alive
branch
from
07fa8c5
to
a6e403a
Compare
hayley-jean
approved these changes
Feb 18, 2021
oskardudycz
reviewed
Feb 18, 2021
| settings.ConnectivitySettings.KeepAliveInterval = keepAliveIntervalMs switch { | ||
| int value when value == -1 => Timeout.InfiniteTimeSpan, | ||
| int value when value >= 0 => TimeSpan.FromMilliseconds(value), | ||
| _ => throw new InvalidSettingException($"Invalid KeepAliveInterval: {keepAliveIntervalMs}") |
There was a problem hiding this comment.
SUGGESTION: Minor, but in RFC is a bit different format: $"Invalid keepAliveInterval {keepAliveInterval}. Please provide a positive integer, or -1 to disable.".
Same comment for code below https://github.com/EventStore/EventStore-Client-Dotnet/pull/107/files#diff-29e93df819e6a1e3940a362a23ca7857372b6098e23b26c18f4f61282c6319bfR184.
oskardudycz
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.