Remove autoAck from Persistent Subscriptions #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayley-jean
force-pushed
the
hayley-jean/remove-auto-ack
branch
3 times, most recently
from
a261b3f
to
e9ea2b1
Compare
oskardudycz
previously approved these changes
Jan 6, 2022
There was a problem hiding this comment.
LGTM 👍
@hayley-jean Regression / regression-ubuntu-18.04/EventStore.Client.Streams-20.6.0 tests are failing, I'm not sure it that's expected.
- Obsolete the SubscribeAsync method, use SubscribeToStreamAsync instead - Throw an error if using SubscribeAsync with autoAck=true - Add SubscribeToStreamAsync without autoAck, messages must be manually acked/nacked - Remove autoAck from SubscribeToAllAsync - Update samples - Remove auto-ack tests
hayley-jean
force-pushed
the
hayley-jean/remove-auto-ack
branch
from
ef7a88e
to
3186014
Compare
oskardudycz
approved these changes
Jan 7, 2022
The regression test is failing because of a previous regression to do with deleted streams, so it's expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes autoAck option when connecting to Persistent Subscriptions. Going forward, subscribers will need to explicitly ack/nack messages using
subscription.Ack(evnt);.See the docs here for instructions on how to ack/nack manually.
Fixes EventStore/EventStore#3113