Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Stream Revision Echoed from the Server #73

Merged
merged 4 commits into from Sep 30, 2020

Conversation

thefringeninja
Copy link
Contributor

Changed: WrongExpectedVersionResult / WrongExpectedVersionException will use values from server

@shaan1337 shaan1337 self-requested a review September 22, 2020 05:53
@thefringeninja thefringeninja force-pushed the wrong-expected-state branch 4 times, most recently from 297091c to 4980c0e Compare September 23, 2020 12:08
shaan1337
shaan1337 previously approved these changes Sep 23, 2020
Copy link
Member

@shaan1337 shaan1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 tested with PR EventStore/EventStore#2679

Copy link
Member

@shaan1337 shaan1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good 👍

@shaan1337 shaan1337 merged commit f798bb2 into EventStore:master Sep 30, 2020
@thefringeninja thefringeninja deleted the wrong-expected-state branch October 6, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants