Don't send password over insecure connection.

EventStore · Nov 15, 2023 · 13bec3a · 13bec3a
1 parent f0374cd
commit 13bec3a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/esdb/endpoint.go b/esdb/endpoint.go
@@ -84,7 +84,7 @@ func newGrpcClient(config Configuration) *grpcClient {
 
 	// Maybe construct RPC credentials from client config.
 	var perRPCCredentials credentials.PerRPCCredentials
-	if config.Username != "" && config.Password != "" {
+	if config.Username != "" && config.Password != "" && !config.DisableTLS {
 		perRPCCredentials = newBasicAuthPerRPCCredentials(config.Username, config.Password)
 	}
 

diff --git a/esdb/options.go b/esdb/options.go
@@ -41,7 +41,7 @@ func configureGrpcCall(ctx context.Context, conf *Configuration, options options
 	newCtx, cancel := context.WithDeadline(ctx, deadline)
 
 	// Maybe use RPC credentials from client method options instead of RPC credentials from client config.
-	if options.credentials() != nil {
+	if options.credentials() != nil && !conf.DisableTLS {
 		perRPCCredentials = newBasicAuthPerRPCCredentials(options.credentials().Login, options.credentials().Password)
 	}