-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
question: Persistent Subscription Docs vs. Code #176
Comments
This is a fair question. As the documentation states it, it's not possible to run persistent subscription on anything than the leader node. All write operations and the subscribe don't need that option indeed. We should remove it from the code to avoid confusion. |
I would be happy to try and make this change myself if you’re interested in
having more contributors.
…On Thu, Jun 6, 2024 at 12:48 AM Yo Eight ***@***.***> wrote:
This is a fair question. As the documentation states it, it's not possible
to run persistent subscription on anything than the leader node. All write
operations and the subscribe don't need that option indeed. We should
remove it from the code to avoid confusion.
—
Reply to this email directly, view it on GitHub
<#176 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BD3VQPC4KCYYE6LIM7ZXMX3ZF4XNVAVCNFSM6AAAAABIFDMLKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQGQYDCMBVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Please have a go if you want. Will be glad to approve your PR! |
Cool, I will give it a shot this weekend. |
@YoEight Two questions:
|
Hey @seanppayne
Yes, you need to fork the repo first then open a pull request on the branch you used to write your patch
You shouldn't have to anything more. Could it be you need to run docker while being root on your machine? I personally always run my docker containers rootless. In any case, don't stress over it, just write your patch, the CI will take care of the testing part. Thanks for your contribution! |
I am just curious, why is there an option for
RequiresLeader
when the docs state the following:Is there a use case for this option or should I default to setting it to true?
The text was updated successfully, but these errors were encountered: