Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

ci: fix environment vars for 20.6.x + fix tests #161

Closed

Conversation

ahjohannessen
Copy link
Contributor

@ahjohannessen ahjohannessen commented Aug 12, 2020

  • due to --insecure mode entails that $users is not present
    projections integration test fails. Fix is to create a stream
    that is always there. Furtermore, user management integration
    tests are skipped if we are on ES 20.6.x series (for now).

@coveralls
Copy link

coveralls commented Aug 12, 2020

Coverage Status

Coverage remained the same at 66.45% when pulling 7826f8f on ahjohannessen:wip-adjust-ci-env-20.6 into 63db9f1 on EventStore:master.

@ahjohannessen
Copy link
Contributor Author

Fails ProjectionsClientITest for es20.6.x because --insecure is used and no $users stream. Can be fixed by creating a new stream prior to running the test.

@ahjohannessen ahjohannessen changed the title ci: fix environment vars for 20.6.x nodes ci: fix environment vars for 20.6.x + fix projections test Aug 12, 2020
@ahjohannessen ahjohannessen force-pushed the wip-adjust-ci-env-20.6 branch 3 times, most recently from 04f5df8 to 8183569 Compare August 12, 2020 12:27
@ahjohannessen ahjohannessen changed the title ci: fix environment vars for 20.6.x + fix projections test ci: fix environment vars for 20.6.x + fix tests Aug 12, 2020
 - due to `--insecure` mode entails that `$users` is not present
   projections integration test fails. Fix is to create a stream
   that is always there. Furtermore, user management integration
   tests are skipped if we are on ES 20.6.x series (for now).
@ahjohannessen
Copy link
Contributor Author

Do not merge, I have a PR soon that enables TLS for TCP/HTTP. That makes it possible to use TLS for 20.6.x tests and avoids --insecure

@alexeyzimarev
Copy link
Member

@ahjohannessen maybe you can set it to Draft, so nobody would be able to merge it? :)

@ahjohannessen ahjohannessen marked this pull request as draft August 18, 2020 15:22
@t3hnar
Copy link
Contributor

t3hnar commented Aug 19, 2020

thx guys.
#162 is merged
can we now remove insecure ?

@ahjohannessen
Copy link
Contributor Author

Yep. This draft is obsolete now, closing it.

@ahjohannessen ahjohannessen deleted the wip-adjust-ci-env-20.6 branch August 19, 2020 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants